Skip to content

fix(crashtracking): repair macOS sidecar connector - #4069

Merged
morrisonlevi merged 1 commit into
masterfrom
fix-macos-crashtracker-sidecar-fd
Jul 27, 2026
Merged

fix(crashtracking): repair macOS sidecar connector#4069
morrisonlevi merged 1 commit into
masterfrom
fix-macos-crashtracker-sidecar-fd

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Has been failing due to incomplete implementation that merged in. Took at stab at it.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi
morrisonlevi requested a review from a team as a code owner July 27, 2026 14:57
@morrisonlevi
morrisonlevi force-pushed the fix-macos-crashtracker-sidecar-fd branch from e785741 to 601834c Compare July 27, 2026 15:06
@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 27, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 53.60% (-7.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 601834c | Docs | Datadog PR Page | Give us feedback!

@morrisonlevi
morrisonlevi merged commit 397bd9e into master Jul 27, 2026
512 of 1027 checks passed
@morrisonlevi
morrisonlevi deleted the fix-macos-crashtracker-sidecar-fd branch July 27, 2026 15:34
@github-actions github-actions Bot added this to the 1.24.0 milestone Jul 27, 2026
@pr-commenter

pr-commenter Bot commented Jul 27, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-07-27 16:35:28

Comparing candidate commit 601834c in PR branch fix-macos-crashtracker-sidecar-fd with baseline commit 0aa19a2 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 190 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+3.388µs; +4.672µs] or [+3.233%; +4.458%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.456µs; +4.604µs] or [+3.265%; +4.350%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+7.578µs; +11.193µs] or [+2.451%; +3.619%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+9.784µs; +13.616µs] or [+3.175%; +4.419%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@morrisonlevi @bwoebi